Skip to content

Use output's parent dir for temp files in standalone convert#1907

Merged
sondavidb merged 1 commit into
awslabs:mainfrom
prafgup:prafulg/not-use-tmp-for-standalone
Mar 30, 2026
Merged

Use output's parent dir for temp files in standalone convert#1907
sondavidb merged 1 commit into
awslabs:mainfrom
prafgup:prafulg/not-use-tmp-for-standalone

Conversation

@prafgup
Copy link
Copy Markdown
Contributor

@prafgup prafgup commented Mar 21, 2026

Issue #, if available:

Description of changes:

Testing performed:

  • Ran integration tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@prafgup prafgup requested a review from a team as a code owner March 21, 2026 12:39
@github-actions github-actions Bot added the go Pull requests that update Go code label Mar 21, 2026
@prafgup prafgup changed the title Skip root path creation for standalone convert and use output dir for temp files Use output dir for temp files in standalone convert Mar 23, 2026
@prafgup prafgup changed the title Use output dir for temp files in standalone convert Use output's parent dir for temp files in standalone convert Mar 23, 2026
sondavidb
sondavidb previously approved these changes Mar 23, 2026
Comment thread cmd/soci/commands/convert.go Outdated
… temp files

Signed-off-by: Praful Gupta <prafulgupta6@gmail.com>
@prafgup prafgup force-pushed the prafulg/not-use-tmp-for-standalone branch from 75446b4 to 62def74 Compare March 24, 2026 00:15
@prafgup prafgup requested a review from sondavidb March 24, 2026 00:15
@sondavidb sondavidb merged commit d6eb44b into awslabs:main Mar 30, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants